]> git.karo-electronics.de Git - karo-tx-linux.git/commit
clk: ti: divider: Provide error check for incoming parameters in set_rate
authorNishanth Menon <nm@ti.com>
Mon, 18 Aug 2014 16:56:54 +0000 (11:56 -0500)
committerTero Kristo <t-kristo@ti.com>
Thu, 21 Aug 2014 15:04:16 +0000 (18:04 +0300)
commit2f1032517623b70920d99529e5c87c8c680ab8bf
treee69dbbf4e0bf9b0ceb07591eea328945936e1531
parent7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9
clk: ti: divider: Provide error check for incoming parameters in set_rate

Check for valid parameters in check rate. Else, we end up getting errors
like:
[    0.000000] Division by zero in kernel.
[    0.000000] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 3.17.0-rc1 #1
[    0.000000] [<c0015160>] (unwind_backtrace) from [<c0011978>] (show_stack+0x10/0x14)
[    0.000000] [<c0011978>] (show_stack) from [<c055f5f4>] (dump_stack+0x78/0x94)
[    0.000000] [<c055f5f4>] (dump_stack) from [<c02e17cc>] (Ldiv0+0x8/0x10)
[    0.000000] [<c02e17cc>] (Ldiv0) from [<c047d228>] (ti_clk_divider_set_rate+0x14/0x14c)
[    0.000000] [<c047d228>] (ti_clk_divider_set_rate) from [<c047a938>] (clk_change_rate+0x138/0x180)
[    0.000000] [<c047a938>] (clk_change_rate) from [<c047a908>] (clk_change_rate+0x108/0x180)

This occurs as part of the inital clock tree update of child clock nodes
where new_rate could be 0 for non functional clocks.

Fixes: b4761198bfaf296 ("CLK: ti: add support for ti divider-clock")
Signed-off-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Tero Kristo <t-kristo@ti.com>
drivers/clk/ti/divider.c