]> git.karo-electronics.de Git - linux-beck.git/commit
phy: coding style fixes
authorSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Sun, 5 Jan 2014 00:17:06 +0000 (03:17 +0300)
committerDavid S. Miller <davem@davemloft.net>
Sun, 5 Jan 2014 00:27:57 +0000 (19:27 -0500)
commit2f53e9047e79b638b155785f03dae8999da93bad
tree3dfad42aaed7f7b0556bc5d14eb491e88b7bd456
parentffeed1beb62f3742693598dfe2f1c010de249bba
phy: coding style fixes

The recent patch from Florian Fainelli fixed all 'checkpatch.pl' errors but left
the numerous warnings:

- including <asm/io.h> instead of <linux/io.h>;

- including <asm/uaccess.h> instead of <linux/uaccess.h>;

- *extern* declaration in .c file;

- block comments using empty /* line;

- block comments not starting with * on the middle lines;

- block comments not having trailing */ on a separate line;

- EXPORT_SYMBOL() not immediately following its function;

- unnecessary {} for signle statement block;

- spaces before tabs.

While fixing these, also fix the following style issues (some of which were
found running 'checkpatch.pl --strict'):

- alignment not matching open paren;

- missing {} on one of the *if* arms where another has them;

- use of sizeof(struct structure) instead of sizeof(*variable);

- multiple assignments on one line;

- empty line before };

- file names in the heading comments;

- missing spaces around operators;

- no {} around multi-line *if* operator's arm;

- unneeded () around subexpressions;

- incomplete kernel-doc comment style;

- comment line exceeding 80 characters;

- missing empty line after declarations.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/phy.c
drivers/net/phy/phy_device.c