]> git.karo-electronics.de Git - karo-tx-linux.git/commit
bridge: send proper message_age in config BPDU
authorstephen hemminger <shemminger@vyatta.com>
Fri, 22 Jul 2011 07:47:06 +0000 (07:47 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 8 Aug 2011 17:35:50 +0000 (10:35 -0700)
commit2fcec01baf7a10f0582268c9e0e6751539d3c95d
treed9d6525128c7f5b8f73b69b5bd01ef03583eb5f8
parente2c6fe7861fc8de41806cb428470f1b6754770bb
bridge: send proper message_age in config BPDU

commit 0c03150e7ea8f7fcd03cfef29385e0010b22ee92 upstream.

A bridge topology with three systems:

      +------+  +------+
      | A(2) |--| B(1) |
      +------+  +------+
           \    /
          +------+
          | C(3) |
          +------+

What is supposed to happen:
 * bridge with the lowest ID is elected root (for example: B)
 * C detects that A->C is higher cost path and puts in blocking state

What happens. Bridge with lowest id (B) is elected correctly as
root and things start out fine initially. But then config BPDU
doesn't get transmitted from A -> C. Because of that
the link from A-C is transistioned to the forwarding state.

The root cause of this is that the configuration messages
is generated with bogus message age, and dropped before
sending.

In the standardmessage_age is supposed to be:
  the time since the generation of the Configuration BPDU by
  the Root that instigated the generation of this Configuration BPDU.

Reimplement this by recording the timestamp (age + jiffies) when
recording config information. The old code incorrectly used the time
elapsed on the ageing timer which was incorrect.

See also:
  https://bugzilla.vyatta.com/show_bug.cgi?id=7164

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/bridge/br_private.h
net/bridge/br_stp.c