]> git.karo-electronics.de Git - linux-beck.git/commit
thunderbolt: Fix double free of drom buffer
authorAndreas Noever <andreas.noever@gmail.com>
Sun, 10 Apr 2016 10:48:27 +0000 (12:48 +0200)
committerBjorn Helgaas <bhelgaas@google.com>
Mon, 2 May 2016 17:09:22 +0000 (12:09 -0500)
commit2ffa9a5d76a75abbc1f95c17959fced666095bdd
tree2bbf292cfa62e714e7544cbdd4436f9e6a2fc03c
parent19bf4d4f909d644110cb587545dc385044ac90a4
thunderbolt: Fix double free of drom buffer

If tb_drom_read() fails, sw->drom is freed but not set to NULL.  sw->drom
is then freed again in the error path of tb_switch_alloc().

The bug can be triggered by unplugging a thunderbolt device shortly after
it is detected by the thunderbolt driver.

Clear sw->drom if tb_drom_read() fails.

[bhelgaas: add Fixes:, stable versions of interest]
Fixes: 343fcb8c70d7 ("thunderbolt: Fix nontrivial endpoint devices.")
Signed-off-by: Andreas Noever <andreas.noever@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
CC: stable@vger.kernel.org # v3.17+
CC: Lukas Wunner <lukas@wunner.de>
drivers/thunderbolt/eeprom.c