]> git.karo-electronics.de Git - linux-beck.git/commit
dt: bindings: net: use boolean dt properties for eee broken modes
authorjbrunet <jbrunet@baylibre.com>
Mon, 19 Dec 2016 15:05:38 +0000 (16:05 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 20 Dec 2016 18:50:50 +0000 (13:50 -0500)
commit308d3165d8b2b98d3dc3d97d6662062735daea67
treeaa26f239778a5429318bb40b26ac3479fa5e45e5
parent57f3986231bb2c69a55ccab1d2b30a00818027ac
dt: bindings: net: use boolean dt properties for eee broken modes

The patches regarding eee-broken-modes was merged before all people
involved could find an agreement on the best way to move forward.

While we agreed on having a DT property to mark particular modes as broken,
the value used for eee-broken-modes mapped the phy register in very direct
way. Because of this, the concern is that it could be used to implement
configuration policies instead of describing a broken HW.

In the end, having a boolean property for each mode seems to be preferred
over one bit field value mapping the register (too) directly.

Cc: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Documentation/devicetree/bindings/net/phy.txt
include/dt-bindings/net/mdio.h [deleted file]