]> git.karo-electronics.de Git - linux-beck.git/commit
ASoC: samsung: Use IRQ safe spin lock calls
authorCharles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thu, 18 Feb 2016 15:47:13 +0000 (15:47 +0000)
committerMark Brown <broonie@kernel.org>
Fri, 19 Feb 2016 15:29:19 +0000 (00:29 +0900)
commit316fa9e09ad76e095b9d7e9350c628b918370a22
treecf71c3a2f24e32ac49e26039eaa5a3fa55cfe17a
parent92e963f50fc74041b5e9e744c330dca48e04f08d
ASoC: samsung: Use IRQ safe spin lock calls

Lockdep warns of a potential lock inversion, i2s->lock is held numerous
times whilst we are under the substream lock (snd_pcm_stream_lock). If
we use the IRQ unsafe spin lock calls, you can also end up locking
snd_pcm_stream_lock whilst under i2s->lock (if an IRQ happens whilst we
are holding i2s->lock). This could result in deadlock.

[   18.147001]        CPU0                    CPU1
[   18.151509]        ----                    ----
[   18.156022]   lock(&(&pri_dai->spinlock)->rlock);
[   18.160701]                                local_irq_disable();
[   18.166622]                                lock(&(&substream->self_group.lock)->rlock);
[   18.174595]                                lock(&(&pri_dai->spinlock)->rlock);
[   18.181806]   <Interrupt>
[   18.184408]     lock(&(&substream->self_group.lock)->rlock);
[   18.190045]
[   18.190045]  *** DEADLOCK ***

This patch changes to using the irq safe spinlock calls, to avoid this
issue.

Fixes: ce8bcdbb61d9 ("ASoC: samsung: i2s: Protect more registers with a spinlock")
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Tested-by: Anand Moon <linux.amoon@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org
sound/soc/samsung/i2s.c