]> git.karo-electronics.de Git - linux-beck.git/commit
[media] vb2: V4L2_BUF_FLAG_DONE is set after DQBUF
authorRicardo Ribalda <ricardo.ribalda@gmail.com>
Mon, 20 Jun 2016 12:47:22 +0000 (09:47 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Fri, 8 Jul 2016 19:16:59 +0000 (16:16 -0300)
commit3171cc2b4eb9831ab4df1d80d0410a945b8bc84e
treed424d3772821c1b782bb8f57e1165aa05e3cf210
parentd14cf19d2b078cf6b4c86e1c2ecd8b5f23556bf3
[media] vb2: V4L2_BUF_FLAG_DONE is set after DQBUF

According to the doc, V4L2_BUF_FLAG_DONE is cleared after DQBUF:

V4L2_BUF_FLAG_DONE 0x00000004  ... After calling the VIDIOC_QBUF or
VIDIOC_DQBUF it is always cleared ...

Unfortunately, it seems that videobuf2 keeps it set after DQBUF. This
can be tested with vivid and dev_debug:

[257604.338082] video1: VIDIOC_DQBUF: 71:33:25.00260479 index=3,
type=vid-cap, flags=0x00002004, field=none, sequence=163,
memory=userptr, bytesused=460800, offset/userptr=0x344b000,
length=460800

This patch forces FLAG_DONE to 0 after calling DQBUF.

Reported-by: Dimitrios Katsaros <patcherwork@gmail.com>
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/v4l2-core/videobuf2-v4l2.c