]> git.karo-electronics.de Git - karo-tx-linux.git/commit
ext4: use proper little-endian bitops
authorAkinobu Mita <akinobu.mita@gmail.com>
Wed, 28 Sep 2011 00:49:47 +0000 (10:49 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Thu, 29 Sep 2011 06:07:53 +0000 (16:07 +1000)
commit31a9ad684c2a23b6514ea5198c4b03ba69499424
treeb4e583848d8db49ae1c084eaceac2c96db56732c
parent855b53a10d33d32303f7be0f53a80d4ff3b35173
ext4: use proper little-endian bitops

ext4_{set,clear}_bit() is defined as __test_and_{set,clear}_bit_le() for
ext4.  Only two ext4_{set,clear}_bit() calls check the return value.  The
rest of calls ignore the return value and they can be replaced with
__{set,clear}_bit_le().

This changes ext4_{set,clear}_bit() from __test_and_{set,clear}_bit_le()
to __{set,clear}_bit_le() and introduces ext4_test_and_{set,clear}_bit()
for the two places where old bit needs to be returned.

This ext4_{set,clear}_bit() change is considered safe, because if someone
uses these macros without noticing the change, new ext4_{set,clear}_bit
don't have return value and causes compiler errors where the return value
is used.

This also removes unused ext4_find_first_zero_bit().

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>
Signed-off-by: Andrew Morton <>
fs/ext4/ext4.h
fs/ext4/ialloc.c