]> git.karo-electronics.de Git - karo-tx-linux.git/commit
Nest rename_lock inside vfsmount_lock
authorAl Viro <viro@zeniv.linux.org.uk>
Tue, 26 Mar 2013 22:25:57 +0000 (18:25 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 5 Apr 2013 16:26:00 +0000 (09:26 -0700)
commit31d34ef4e00e43651a9102a4215233f17c5607fb
treef85a3b6b48f8efc56ed140a72d28a542d67103af
parent3cdc03d8c552990fa4fbd5acfdfa44fe6d3a32a9
Nest rename_lock inside vfsmount_lock

commit 7ea600b5314529f9d1b9d6d3c41cb26fce6a7a4a upstream.

... lest we get livelocks between path_is_under() and d_path() and friends.

The thing is, wrt fairness lglocks are more similar to rwsems than to rwlocks;
it is possible to have thread B spin on attempt to take lock shared while thread
A is already holding it shared, if B is on lower-numbered CPU than A and there's
a thread C spinning on attempt to take the same lock exclusive.

As the result, we need consistent ordering between vfsmount_lock (lglock) and
rename_lock (seq_lock), even though everything that takes both is going to take
vfsmount_lock only shared.

Spotted-by: Brad Spengler <spender@grsecurity.net>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/dcache.c