]> git.karo-electronics.de Git - karo-tx-linux.git/commit
USB: xhci - fix bit definitions for IMAN register
authorDmitry Torokhov <dtor@vmware.com>
Mon, 25 Feb 2013 18:56:01 +0000 (10:56 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Mar 2013 19:12:26 +0000 (12:12 -0700)
commit31e8d29ccf1844a84b7c07d511e6a92d9f99cc11
tree512ab2a07fda6dcab2357bb2cd0aafc20a709c72
parent56d833d3ed356e861ede0dd1c530ed5185d1215e
USB: xhci - fix bit definitions for IMAN register

commit f8264340e694604863255cc0276491d17c402390 upstream.

According to XHCI specification (5.5.2.1) the IP is bit 0 and IE is bit 1
of IMAN register. Previously their definitions were reversed.

Even though there are no ill effects being observed from the swapped
definitions (because IMAN_IP is RW1C and in legacy PCI case we come in
with it already set to 1 so it was clearing itself even though we were
setting IMAN_IE instead of IMAN_IP), we should still correct the values.

This patch should be backported to kernels as old as 2.6.36, that
contain the commit 4e833c0b87a30798e67f06120cecebef6ee9644c "xhci: don't
re-enable IE constantly".

Signed-off-by: Dmitry Torokhov <dtor@vmware.com>
Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/xhci.h