]> git.karo-electronics.de Git - karo-tx-linux.git/commit
pptp: fix stack info leak in pptp_getname()
authorMathias Krause <minipli@googlemail.com>
Wed, 19 Nov 2014 17:05:26 +0000 (18:05 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 6 Dec 2014 23:55:34 +0000 (15:55 -0800)
commit32b849a714aad7701a1fc53953272b83a6dc483a
tree66c6118354376c1b401b22c92ed092744df693ab
parent25c44b708508af210a8ae402263852861e63dc0d
pptp: fix stack info leak in pptp_getname()

[ Upstream commit a5f6fc28d6e6cc379c6839f21820e62262419584 ]

pptp_getname() only partially initializes the stack variable sa,
particularly only fills the pptp part of the sa_addr union. The code
thereby discloses 16 bytes of kernel stack memory via getsockname().

Fix this by memset(0)'ing the union before.

Cc: Dmitry Kozlov <xeb@mail.ru>
Signed-off-by: Mathias Krause <minipli@googlemail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ppp/pptp.c