]> git.karo-electronics.de Git - karo-tx-linux.git/commit
dcbnl: fix various netlink info leaks
authorMathias Krause <minipli@googlemail.com>
Sat, 9 Mar 2013 05:52:21 +0000 (05:52 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Mar 2013 20:05:02 +0000 (13:05 -0700)
commit32ceecc2587ac7e079f17dbc9d5158928667baad
treeb2c94f11009103aa536863f880cad60ca8aa653c
parent78d3a467490d72c699393947f1e566fa28672947
dcbnl: fix various netlink info leaks

[ Upstream commit 29cd8ae0e1a39e239a3a7b67da1986add1199fc0 ]

The dcb netlink interface leaks stack memory in various places:
* perm_addr[] buffer is only filled at max with 12 of the 32 bytes but
  copied completely,
* no in-kernel driver fills all fields of an IEEE 802.1Qaz subcommand,
  so we're leaking up to 58 bytes for ieee_ets structs, up to 136 bytes
  for ieee_pfc structs, etc.,
* the same is true for CEE -- no in-kernel driver fills the whole
  struct,

Prevent all of the above stack info leaks by properly initializing the
buffers/structures involved.

Signed-off-by: Mathias Krause <minipli@googlemail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/dcb/dcbnl.c