]> git.karo-electronics.de Git - karo-tx-linux.git/commit
asn1: additional sanity checking during BER decoding (CVE-2008-1673)
authorChris Wright <chrisw@sous-sol.org>
Wed, 4 Jun 2008 16:16:33 +0000 (09:16 -0700)
committerChris Wright <chrisw@sous-sol.org>
Fri, 6 Jun 2008 23:04:46 +0000 (16:04 -0700)
commit33afb8403f361919aa5c8fe1d0a4f5ddbfbbea3c
tree2b95d72be1b19dbb8d3963f8bd9a798652831668
parenta82a9bfebc74862798a3f6949fe6f6a959c1fd4e
asn1: additional sanity checking during BER decoding (CVE-2008-1673)

upstream commit: ddb2c43594f22843e9f3153da151deaba1a834c5

- Don't trust a length which is greater than the working buffer.
  An invalid length could cause overflow when calculating buffer size
  for decoding oid.

- An oid length of zero is invalid and allows for an off-by-one error when
  decoding oid because the first subid actually encodes first 2 subids.

- A primitive encoding may not have an indefinite length.

Thanks to Wei Wang from McAfee for report.

Cc: Steven French <sfrench@us.ibm.com>
Cc: stable@kernel.org
Acked-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/cifs/asn1.c
net/ipv4/netfilter/nf_nat_snmp_basic.c