]> git.karo-electronics.de Git - linux-beck.git/commit
tty: an overflow of multiplication in drivers/tty/cyclades.c
authorQixue Xiao <s2exqx@gmail.com>
Fri, 20 Dec 2013 09:51:12 +0000 (17:51 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 20 Dec 2013 20:21:57 +0000 (12:21 -0800)
commit351d6204bfc814a1aee300296d2f54460ffff172
tree8ee90f783108f35518c50fb9a43f2191e88e5a00
parent4903713cac8bd41b576e4e3eff3d54bd199a7737
tty: an overflow of multiplication in drivers/tty/cyclades.c

there is an overflow in the code :
cyz_polling_cycle = (arg * HZ) / 1000,
the multiplicator arg comes from user, so it may be an overflow if
arg is a big number. And the value of cyc_polling_cycle will be
wrong when it is used next time.

Reported-by: Qixue Xiao <xiaoqixue_1@163.com>
Suggested-by: Yongjian Xu <xuyongjiande@gmail.com>
Suggested-by: Yu Chen <chyyuu@gmail.com>
Signed-off-by: Qixue Xiao <xiaoqixue_1@163.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/cyclades.c