]> git.karo-electronics.de Git - karo-tx-linux.git/commit
TTY: drop driver reference in tty_open fail path
authorJiri Slaby <jslaby@suse.cz>
Wed, 12 Oct 2011 09:32:42 +0000 (11:32 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 11 Nov 2011 17:35:12 +0000 (09:35 -0800)
commit36174dd629350d0654982977d7795ca28475c16f
treeaa8bd3253d87b0e41046940237134c60aee8d86b
parent47bbdafa8ab90e3d4b7a4c6dd9bf54f7bc6df66d
TTY: drop driver reference in tty_open fail path

commit c290f8358acaeffd8e0c551ddcc24d1206143376 upstream.

When tty_driver_lookup_tty fails in tty_open, we forget to drop a
reference to the tty driver. This was added by commit 4a2b5fddd5 (Move
tty lookup/reopen to caller).

Fix that by adding tty_driver_kref_put to the fail path.

I will refactor the code later. This is for the ease of backporting to
stable.

Introduced-in: v2.6.28-rc2
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Acked-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/tty/tty_io.c