]> git.karo-electronics.de Git - linux-beck.git/commit
staging: ks7010: return on failure
authorSudip Mukherjee <sudipm.mukherjee@gmail.com>
Sun, 4 Sep 2016 15:00:18 +0000 (20:30 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 12 Sep 2016 09:01:52 +0000 (11:01 +0200)
commit369e1b69c1a2ed9fb66cfd2a6fe2f7340c64cd49
tree4d7510c2c8b2ef9f36d1ebc9bdaaa9cb770f2e7e
parent98a3c4d7ae9ad0ca8a8edbed5f37e559673aa3ac
staging: ks7010: return on failure

On failure we were jumping to error_out0 where we were trying
sdio_release_host() but at this point of execution we still have not
done sdio_claim_host() and as a result host->claimed can still be 0.
And if host->claimed is 0 then WARN_ON(!host->claimed) will give
a warning.
Moreover, if it is still not claimed then mmc_host->claim_cnt will be 0
and mmc_release_host() will do "if (--host->claim_cnt)" and thus the
condition will become true.
Lets just return the value on allocation failure instead of trying to
release the host before claiming it.

Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/ks7010/ks7010_sdio.c