]> git.karo-electronics.de Git - karo-tx-linux.git/commit
x86/irq: Check vector allocation early
authorThomas Gleixner <tglx@linutronix.de>
Thu, 31 Dec 2015 16:30:48 +0000 (16:30 +0000)
committerThomas Gleixner <tglx@linutronix.de>
Fri, 15 Jan 2016 12:44:00 +0000 (13:44 +0100)
commit3716fd27a604d61a91cda47083504971486b80f1
tree7c996f0b3da0891e61a62304eb9290159956fd08
parent95ffeb4b5baca266e1d0d2bc90f1513e6f419cdd
x86/irq: Check vector allocation early

__assign_irq_vector() uses the vector_cpumask which is assigned by
apic->vector_allocation_domain() without doing basic sanity checks. That can
result in a situation where the final assignement of a newly found vector
fails in apic->cpu_mask_to_apicid_and(). So we have to do rollbacks for no
reason.

apic->cpu_mask_to_apicid_and() only fails if

  vector_cpumask & requested_cpumask & cpu_online_mask

is empty.

Check for this condition right away and if the result is empty try immediately
the next possible cpu in the requested mask. So in case of a failure the old
setting is unchanged and we can remove the rollback code.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Borislav Petkov <bp@alien8.de>
Tested-by: Joe Lawrence <joe.lawrence@stratus.com>
Cc: Jiang Liu <jiang.liu@linux.intel.com>
Cc: Jeremiah Mahler <jmmahler@gmail.com>
Cc: andy.shevchenko@gmail.com
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: stable@vger.kernel.org #4.3+
Link: http://lkml.kernel.org/r/20151231160106.561877324@linutronix.de
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
arch/x86/kernel/apic/vector.c