]> git.karo-electronics.de Git - karo-tx-linux.git/commit
KEYS: Revert one application of "Fix unreachable code" patch
authorDavid Howells <dhowells@redhat.com>
Thu, 21 Feb 2013 12:00:25 +0000 (12:00 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Feb 2013 13:38:32 +0000 (05:38 -0800)
commit373f58fd7f38decf2756053f0ab4fb8b0662a32c
tree4ced9f18c09b7d04628cdce2e40209b3a54d7f06
parentc73fc1e7acbbf8c6346eb6035751bee9ca472d8f
KEYS: Revert one application of "Fix unreachable code" patch

commit fe9453a1dcb5fb146f9653267e78f4a558066f6f upstream.

A patch to fix some unreachable code in search_my_process_keyrings() got
applied twice by two different routes upstream as commits e67eab39bee2
and b010520ab3d2 (both "fix unreachable code").

Unfortunately, the second application removed something it shouldn't
have and this wasn't detected by GIT.  This is due to the patch not
having sufficient lines of context to distinguish the two places of
application.

The effect of this is relatively minor: inside the kernel, the keyring
search routines may search multiple keyrings and then prioritise the
errors if no keys or negative keys are found in any of them.  With the
extra deletion, the presence of a negative key in the thread keyring
(causing ENOKEY) is incorrectly overridden by an error searching the
process keyring.

So revert the second application of the patch.

Signed-off-by: David Howells <dhowells@redhat.com>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
security/keys/process_keys.c