non-swapcache pages in end_swap_bio_read()
There is no guarantee that page in end_swap_bio_read is in swapcache so we
need to check it before calling page_swap_info(). Otherwise kernel hits a
bug on like the one below. Introduced in "mm: remove compressed copy from
zram in-memory"
kernel BUG at mm/swapfile.c:2361!
invalid opcode: 0000 [#1] SMP
Modules linked in:
CPU: 1 PID: 0 Comm: swapper/1 Not tainted 3.10.0-rc4-next-
20130607+ #61
Hardware name: Bochs Bochs, BIOS Bochs 01/01/2007
task:
ffff88001e5ccfc0 ti:
ffff88001e5ea000 task.ti:
ffff88001e5ea000
RIP: 0010:[<
ffffffff811462eb>] [<
ffffffff811462eb>] page_swap_info+0xab/0xb0
RSP: 0000:
ffff88001ec03c78 EFLAGS:
00010246
RAX:
0100000000000009 RBX:
ffffea0000794780 RCX:
0000000000000c0b
RDX:
0000000000000046 RSI:
0000000000000000 RDI:
0000000000000000
RBP:
ffff88001ec03c88 R08:
0000000000000000 R09:
0000000000000000
R10:
0000000000000000 R11:
0000000000000000 R12:
0000000000000000
R13:
0000000000000001 R14:
ffff88001e7f6200 R15:
0000000000001000
FS:
0000000000000000(0000) GS:
ffff88001ec00000(0000) knlGS:
0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0:
000000008005003b
CR2:
0000000000000000 CR3:
000000000240b000 CR4:
00000000000006e0
DR0:
0000000000000000 DR1:
0000000000000000 DR2:
0000000000000000
DR3:
0000000000000000 DR6:
00000000ffff0ff0 DR7:
0000000000000400
Stack:
ffffea0000794780 ffff88001e7f6200 ffff88001ec03cb8 ffffffff81145486
ffff88001e5cd5c0 ffff88001c02cd20 0000000000001000 0000000000000000
ffff88001ec03cc8 ffffffff81199518 ffff88001ec03d28 ffffffff81518ec3
Call Trace:
<IRQ>
[<
ffffffff81145486>] end_swap_bio_read+0x96/0x130
[<
ffffffff81199518>] bio_endio+0x18/0x40
[<
ffffffff81518ec3>] blk_update_request+0x213/0x540
[<
ffffffff81518fa0>] ? blk_update_request+0x2f0/0x540
[<
ffffffff817986a6>] ? ata_hsm_qc_complete+0x46/0x130
[<
ffffffff81519212>] blk_update_bidi_request+0x22/0x90
[<
ffffffff8151b9ea>] blk_end_bidi_request+0x2a/0x80
[<
ffffffff8151ba8b>] blk_end_request+0xb/0x10
[<
ffffffff817693aa>] scsi_io_completion+0xaa/0x6b0
[<
ffffffff817608d8>] scsi_finish_command+0xc8/0x130
[<
ffffffff81769aff>] scsi_softirq_done+0x13f/0x160
[<
ffffffff81521ebc>] blk_done_softirq+0x7c/0x90
[<
ffffffff81049030>] __do_softirq+0x130/0x3f0
[<
ffffffff810d454e>] ? handle_irq_event+0x4e/0x70
[<
ffffffff81049405>] irq_exit+0xa5/0xb0
[<
ffffffff81003cb1>] do_IRQ+0x61/0xe0
[<
ffffffff81c2832f>] common_interrupt+0x6f/0x6f
<EOI>
[<
ffffffff8107ebff>] ? local_clock+0x4f/0x60
[<
ffffffff81c27f85>] ? _raw_spin_unlock_irq+0x35/0x50
[<
ffffffff81c27f7b>] ? _raw_spin_unlock_irq+0x2b/0x50
[<
ffffffff81078bd0>] finish_task_switch+0x80/0x110
[<
ffffffff81078b93>] ? finish_task_switch+0x43/0x110
[<
ffffffff81c2525c>] __schedule+0x32c/0x8c0
[<
ffffffff81c2c010>] ? notifier_call_chain+0x150/0x150
[<
ffffffff81c259d4>] schedule+0x24/0x70
[<
ffffffff81c25d42>] schedule_preempt_disabled+0x22/0x30
[<
ffffffff81093645>] cpu_startup_entry+0x335/0x380
[<
ffffffff81c1ed7e>] start_secondary+0x217/0x219
Code: 69 bc 16 82 48 c7 c7 77 bc 16 82 31 c0 49 c1 ec 39 49 c1 e9 10 41 83 e1 01 e8 6c d2 ad 00 5b 4a 8b 04 e5 e0 bf 14 83 41 5c c9 c3 <0f> 0b eb fe 90 48 8b 07 55 48 89 e5 a9 00 00 01 00 74 12 e8 3d
RIP [<
ffffffff811462eb>] page_swap_info+0xab/0xb0
RSP <
ffff88001ec03c78>
Signed-off-by: Artem Savkov <artem.savkov@gmail.com>
Cc: Dan Magenheimer <dan.magenheimer@oracle.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Konrad Rzeszutek Wilk <konrad@darnok.org>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Nitin Gupta <ngupta@vflare.org>
Cc: Seth Jennings <sjenning@linux.vnet.ibm.com>
Cc: Shaohua Li <shli@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>