]> git.karo-electronics.de Git - linux-beck.git/commit
PCI: pciehp: Prioritize data-link event over presence detect
authorAshok Raj <ashok.raj@intel.com>
Sat, 19 Nov 2016 08:32:45 +0000 (00:32 -0800)
committerBjorn Helgaas <bhelgaas@google.com>
Wed, 7 Dec 2016 23:00:44 +0000 (17:00 -0600)
commit385895fef6b5f4723e33d0e58251c45bc708132d
tree615e9d8a71998de31f3c9c742cfed26ef6822439
parentb11d207fb229943d75c17cef4ae3fa980f0cee79
PCI: pciehp: Prioritize data-link event over presence detect

If Slot Status indicates changes in both Data Link Layer Status and
Presence Detect, prioritize the Link status change.

When both events are observed, pciehp currently relies on the Slot Status
Presence Detect State (PDS) to agree with the Link Status Data Link Layer
Active status.  The Presence Detect State, however, may be set to 1 through
out-of-band presence detect even if the link is down, which creates
conflicting events.

Since the Link Status accurately reflects the reachability of the
downstream bus, the Link Status event should take precedence over a
Presence Detect event.  Skip checking the PDC status if we handled a link
event in the same handler.

Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Keith Busch <keith.busch@intel.com>
drivers/pci/hotplug/pciehp_hpc.c