]> git.karo-electronics.de Git - linux-beck.git/commit
staging/lustre/osc: Revert erroneous list_for_each_entry_safe use
authorOleg Drokin <green@linuxhacker.ru>
Wed, 7 Dec 2016 03:53:48 +0000 (22:53 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 9 Jan 2017 07:32:18 +0000 (08:32 +0100)
commit38b2dc0b0f380984cd4fcc208497f8366f85f856
tree7d09b2ca263811e013f1bef1ae1d57546f13128b
parentbf6a9b31e8a9cbdb6f67f84882fcf7d252e43d6f
staging/lustre/osc: Revert erroneous list_for_each_entry_safe use

commit cd15dd6ef4ea11df87f717b8b1b83aaa738ec8af upstream.

I have been having a lot of unexplainable crashes in osc_lru_shrink
lately that I could not see a good explanation for and then I found
this patch that slip under the radar somehow that incorrectly
converted while loop for lru list iteration into
list_for_each_entry_safe totally ignoring that in the body of
the loop we drop spinlocks guarding this list and move list entries
around.
Not sure why it was not showing up right away, perhaps some of the
more recent LRU changes committed caused some extra pressure on this
code that finally highlighted the breakage.

Reverts: 8adddc36b1fc ("staging: lustre: osc: Use list_for_each_entry_safe")
CC: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/lustre/lustre/osc/osc_page.c