]> git.karo-electronics.de Git - karo-tx-linux.git/commit
blk-cgroup: don't quiesce the queue on policy activate/deactivate
authorJens Axboe <axboe@fb.com>
Wed, 18 Jan 2017 22:37:27 +0000 (15:37 -0700)
committerJens Axboe <axboe@fb.com>
Wed, 18 Jan 2017 22:37:27 +0000 (15:37 -0700)
commit38dbb7dd4db184da4d2673f4bb963f7006465c37
tree7d34184c97b07d1aed08731fff17dad9efbbcdf1
parent6c0ca7ae292adea09b8bdd33a524bb9326c3e989
blk-cgroup: don't quiesce the queue on policy activate/deactivate

There's no potential harm in quiescing the queue, but it also doesn't
buy us anything. And we can't run the queue async for policy
deactivate, since we could be in the path of tearing the queue down.
If we schedule an async run of the queue at that time, we're racing
with queue teardown AFTER having we've already torn most of it down.

Reported-by: Omar Sandoval <osandov@fb.com>
Fixes: 4d199c6f1c84 ("blk-cgroup: ensure that we clear the stop bit on quiesced queues")
Tested-by: Omar Sandoval <osandov@fb.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
block/blk-cgroup.c