]> git.karo-electronics.de Git - karo-tx-linux.git/commit
[PATCH] TCP: Fix sorting of SACK blocks.
authorBaruch Even <baruch@ev-en.org>
Fri, 2 Feb 2007 21:16:09 +0000 (13:16 -0800)
committerChris Wright <chrisw@sous-sol.org>
Mon, 5 Feb 2007 16:31:45 +0000 (08:31 -0800)
commit39460cfb25adbafd7141a79b8f51769daacaa0d7
treed410e8da4a8cf5126471c8b91d27146412ba5a20
parent26cc0cab4c76d353c8f72fe3fe3e822d738f5c13
[PATCH] TCP: Fix sorting of SACK blocks.

The sorting of SACK blocks actually munges them rather than sort,
causing the TCP stack to ignore some SACK information and breaking the
assumption of ordered SACK blocks after sorting.

The sort takes the data from a second buffer which isn't moved causing
subsequent data moves to occur from the wrong location. The fix is to
use a temporary buffer as a normal sort does.

Signed-off-By: Baruch Even <baruch@ev-en.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
net/ipv4/tcp_input.c