]> git.karo-electronics.de Git - karo-tx-linux.git/commit
dmaengine: at_hdmac: remove clear-on-read in atc_dostart()
authorNicolas Ferre <nicolas.ferre@atmel.com>
Mon, 16 Apr 2012 12:46:30 +0000 (14:46 +0200)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 11 May 2012 12:14:34 +0000 (13:14 +0100)
commit39fd81649ec76c39861105e9713adedba6e5432b
tree251d546513324eff422cb3a9bbb41b11349553fe
parent75da54d1e53bc81447e82c5f5d0f5112d7a3aed5
dmaengine: at_hdmac: remove clear-on-read in atc_dostart()

commit ed8b0d67f33518a16c6b2450fe5ebebf180c2d04 upstream.

This loop on EBCISR register was designed to clear IRQ sources before enabling
a DMA channel. This register is clear-on-read so a race condition can appear if
another channel is already active and has just finished its transfer.
Removing this read on EBCISR is fixing the issue as there is no case where an IRQ
could be pending: we already make sure that this register is drained at probe()
time and during resume.

Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: Vinod Koul <vinod.koul@linux.intel.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/dma/at_hdmac.c