]> git.karo-electronics.de Git - karo-tx-linux.git/commit
devfreq_cooling: pass a pointer to devfreq in the power model callbacks
authorJavi Merino <javi.merino@arm.com>
Thu, 15 Sep 2016 14:44:23 +0000 (15:44 +0100)
committerZhang Rui <rui.zhang@intel.com>
Wed, 23 Nov 2016 02:07:35 +0000 (10:07 +0800)
commit3aa5374376746f20a27be8682be7f91c8b71d1d8
treeacf8f0716d84c5f1c5bc1960468e6d88f6d2c9e1
parent1cea4e7776b7e9096b696eeb66364f51a8d321ec
devfreq_cooling: pass a pointer to devfreq in the power model callbacks

When the devfreq cooling device was designed, it was an oversight not to
pass a pointer to the struct devfreq as the first parameters of the
callbacks.  The design patterns of the kernel suggest it for a good
reason.

By passing a pointer to struct devfreq, the driver can register one
function that works with multiple devices.  With the current
implementation, a driver that can work with multiple devices has to
create multiple copies of the same function with different parameters so
that each devfreq_cooling_device can use the appropriate one.  By
passing a pointer to struct devfreq, the driver can identify which
device it's referring to.

Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Eduardo Valentin <edubezval@gmail.com>
Reviewed-by: Punit Agrawal <punit.agrawal@arm.com>
Reviewed-by: Ørjan Eide <orjan.eide@arm.com>
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Signed-off-by: Javi Merino <javi.merino@arm.com>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
drivers/thermal/devfreq_cooling.c
include/linux/devfreq_cooling.h