]> git.karo-electronics.de Git - karo-tx-linux.git/commit
net: Fix issue with netdev_tx_reset_queue not resetting queue from XOFF state
authorAlexander Duyck <alexander.h.duyck@intel.com>
Tue, 7 Feb 2012 02:29:01 +0000 (02:29 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 12 May 2012 16:32:19 +0000 (09:32 -0700)
commit3b50cf3c908f2d025617f3e593c132fdfbc0eb4b
tree21c657cb5db7c4fc1728058a67ef65a0c72b30c4
parent4680d7ad59b1aeab6bd04d326523cf8e6b305f02
net: Fix issue with netdev_tx_reset_queue not resetting queue from XOFF state

[ Upstream commit 5c4903549c05bbb373479e0ce2992573c120654a ]

We are seeing dev_watchdog hangs on several drivers.  I suspect this is due
to the __QUEUE_STATE_STACK_XOFF bit being set prior to a reset for link
change, and then not being cleared by netdev_tx_reset_queue.  This change
corrects that.

In addition we were seeing dev_watchdog hangs on igb after running the
ethtool tests.  We found this to be due to the fact that the ethtool test
runs the same logic as ndo_start_xmit, but we were never clearing the XOFF
flag since the loopback test in ethtool does not do byte queue accounting.

Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Tested-by: Stephen Ko <stephen.s.ko@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/linux/netdevice.h