]> git.karo-electronics.de Git - karo-tx-linux.git/commit
USB: ftdi_sio: revert "USB: ftdi_sio: fix DTR/RTS line modes"
authorJohan Hovold <jhovold@gmail.com>
Sun, 12 Sep 2010 14:31:45 +0000 (16:31 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 21 Mar 2011 19:44:03 +0000 (12:44 -0700)
commit3b63c721e4bb4d869cb623e8f24e053ecf05418e
treeadeb248ec7d1d004d4921cbb46ba4a8f09a5f191
parent967e5c6eb86a2ac562a62e142d36cdad451d36b0
USB: ftdi_sio: revert "USB: ftdi_sio: fix DTR/RTS line modes"

commit 677aeafe19e88c282af74564048243ccabb1c590 upstream.

This reverts commit 6a1a82df91fa0eb1cc76069a9efe5714d087eccd.

RTS and DTR should not be modified based on CRTSCTS when calling
set_termios.

Modem control lines are raised at port open by the tty layer and should stay
raised regardless of whether hardware flow control is enabled or not.

This is in conformance with the way serial ports work today and many
applications depend on this behaviour to be able to talk to hardware
implementing hardware flow control (without the applications actually using
it).

Hardware which expects different behaviour on these lines can always
use TIOCMSET/TIOCMBI[SC] after port open to change them.

Reported-by: Daniel Mack <daniel@caiaq.de>
Reported-by: Dave Mielke <dave@mielke.cc>
Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/serial/ftdi_sio.c