]> git.karo-electronics.de Git - karo-tx-linux.git/commit
md: move revalidate_disk() back outside open_mutex
authorDan Williams <dan.j.williams@intel.com>
Sat, 7 Aug 2010 01:01:59 +0000 (18:01 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 13 Aug 2010 20:30:48 +0000 (13:30 -0700)
commit3b9f17f709e0b691940bfd9eda45b716932696f6
tree98383eafacfcf86c934218294188f797ad51f0d6
parent8a4ddef0916fea7b0dae2ae5b5fc287029e2208e
md: move revalidate_disk() back outside open_mutex

commit 147e0b6a639ac581ca3bf627bedc3f4a6d3eca66 upstream.

Commit b821eaa5 "md: remove ->changed and related code" moved
revalidate_disk() under open_mutex, and lockdep noticed.

[ INFO: possible circular locking dependency detected ]
2.6.32-mdadm-locking #1
-------------------------------------------------------
mdadm/3640 is trying to acquire lock:
 (&bdev->bd_mutex){+.+.+.}, at: [<ffffffff811acecb>] revalidate_disk+0x5b/0x90

but task is already holding lock:
 (&mddev->open_mutex){+.+...}, at: [<ffffffffa055e07a>] do_md_stop+0x4a/0x4d0 [md_mod]

which lock already depends on the new lock.

It is suitable for 2.6.35.x

Reported-by: Przemyslaw Czarnowski <przemyslaw.hawrylewicz.czarnowski@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/md/md.c