]> git.karo-electronics.de Git - linux-beck.git/commit
skd: fix msix error handling
authorArnd Bergmann <arnd@arndb.de>
Wed, 9 Nov 2016 12:55:34 +0000 (13:55 +0100)
committerJens Axboe <axboe@fb.com>
Thu, 10 Nov 2016 05:53:45 +0000 (22:53 -0700)
commit3bc8492f009c76a9e77cad6e200b0748d3972fa0
tree6c359501445272e2b60dc139ac51f888f6173599
parentae5b2ec8ad5e017126cd4552220f25ce8a6b92e9
skd: fix msix error handling

As reported by gcc -Wmaybe-uninitialized, the cleanup path for
skd_acquire_msix tries to free the already allocated msi-x vectors
in reverse order, but the index variable may not have been
used yet:

drivers/block/skd_main.c: In function ‘skd_acquire_irq’:
drivers/block/skd_main.c:3890:8: error: ‘i’ may be used uninitialized in this function [-Werror=maybe-uninitialized]

This changes the failure path to skip releasing the interrupts
if we have not started requesting them yet.

Fixes: 180b0ae77d49 ("skd: use pci_alloc_irq_vectors")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@fb.com>
drivers/block/skd_main.c