]> git.karo-electronics.de Git - linux-beck.git/commit
net: phy: leds: Fix truncated LED trigger names
authorGeert Uytterhoeven <geert+renesas@glider.be>
Wed, 25 Jan 2017 10:39:50 +0000 (11:39 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 25 Jan 2017 19:40:19 +0000 (14:40 -0500)
commit3c880eb0205222bb062970085ebedc73ec8dfd14
tree4c2a2b25a501d08ac1c9ac0381e963a3c725137b
parentd6f8cfa3dea294eabf8f302e90176dd6381fb66e
net: phy: leds: Fix truncated LED trigger names

Commit 4567d686f5c6d955 ("phy: increase size of MII_BUS_ID_SIZE and
bus_id") increased the size of MII bus IDs, but forgot to update the
private definition in <linux/phy_led_triggers.h>.
This may cause:
  1. Truncation of LED trigger names,
  2. Duplicate LED trigger names,
  3. Failures registering LED triggers,
  4. Crashes due to bad error handling in the LED trigger failure path.

To fix this, and prevent the definitions going out of sync again in the
future, let the PHY LED trigger code use the existing MII_BUS_ID_SIZE
definition.

Example:
  - Before I had triggers "ee700000.etherne:01:100Mbps" and
    "ee700000.etherne:01:10Mbps",
  - After the increase of MII_BUS_ID_SIZE, both became
    "ee700000.ethernet-ffffffff:01:" => FAIL,
  - Now, the triggers are "ee700000.ethernet-ffffffff:01:100Mbps" and
    "ee700000.ethernet-ffffffff:01:10Mbps", which are unique again.

Fixes: 4567d686f5c6d955 ("phy: increase size of MII_BUS_ID_SIZE and bus_id")
Fixes: 2e0bc452f4721520 ("net: phy: leds: add support for led triggers on phy link state change")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/phy_led_triggers.h