]> git.karo-electronics.de Git - karo-tx-linux.git/commit
wl1251: fix crash on remove due to premature kfree
authorGrazvydas Ignotas <notasas@gmail.com>
Thu, 26 Apr 2012 20:07:43 +0000 (23:07 +0300)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 11 May 2012 12:14:55 +0000 (13:14 +0100)
commit3c94aaf04ec842bbbf400277b09ec570874868d2
treee60162fb611a6c864c9db6c03ec6764b11bb74f4
parentf4f204d6a435431cee1f8a0d21417eaf4c53ef55
wl1251: fix crash on remove due to premature kfree

commit 328c32f0f85467af5a6c4c3289e168d9ad2555af upstream.

Currently SDIO glue frees it's own structure before calling
wl1251_free_hw(), which in turn calls ieee80211_unregister_hw().
The later call may result in a need to communicate with the chip
to stop it (as it happens now if the interface is still up before
rmmod), which means calls are made back to the glue, resulting in
freed memory access.

Fix this by freeing glue data last.

Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/net/wireless/wl1251/sdio.c