]> git.karo-electronics.de Git - karo-tx-linux.git/commit
ext3: Fix format string issues
authorLars-Peter Clausen <lars@metafoo.de>
Sat, 9 Mar 2013 14:28:44 +0000 (15:28 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Mar 2013 20:10:53 +0000 (13:10 -0700)
commit3d1e1dba617554975426e7c7477321bd26f71789
treec5249e19c8192ab6bedac6b455d310a4ba72e733
parentcdef9602fbf1871a43f0f1b5cea10dd0f275167d
ext3: Fix format string issues

commit 8d0c2d10dd72c5292eda7a06231056a4c972e4cc upstream.

ext3_msg() takes the printk prefix as the second parameter and the
format string as the third parameter. Two callers of ext3_msg omit the
prefix and pass the format string as the second parameter and the first
parameter to the format string as the third parameter. In both cases
this string comes from an arbitrary source. Which means the string may
contain format string characters, which will
lead to undefined and potentially harmful behavior.

The issue was introduced in commit 4cf46b67eb("ext3: Unify log messages
in ext3") and is fixed by this patch.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ext3/super.c