]> git.karo-electronics.de Git - karo-tx-linux.git/commit
mISDN: Fix wrong usage of flush_work_sync while holding locks
authorKarsten Keil <keil@b1-systems.de>
Thu, 13 Sep 2012 04:36:20 +0000 (04:36 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 2 Oct 2012 17:39:12 +0000 (10:39 -0700)
commit3da7f1ade823595e37e37bca09d9d9f24c945e9a
tree8ba28d15417a09bbc560046e50a837c639c7effd
parentdff9a4f031d1804f41b0f45c53543284b93548df
mISDN: Fix wrong usage of flush_work_sync while holding locks

commit 4b921eda53366b319602351ff4d7256fafa4bd1b upstream.

It is a bad idea to hold a spinlock and call flush_work_sync.
Move the workqueue cleanup outside the spinlock and use cancel_work_sync,
on closing the channel this seems to be the more correct function.
Remove the never used and constant return value of mISDN_freebchannel.

Signed-off-by: Karsten Keil <keil@b1-systems.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/isdn/hardware/mISDN/avmfritz.c
drivers/isdn/hardware/mISDN/mISDNipac.c
drivers/isdn/hardware/mISDN/mISDNisar.c
drivers/isdn/hardware/mISDN/netjet.c
drivers/isdn/hardware/mISDN/w6692.c
drivers/isdn/mISDN/hwchannel.c
include/linux/mISDNhw.h