]> git.karo-electronics.de Git - karo-tx-linux.git/commit
ethtool: Allow zero-length register dumps again
authorBen Hutchings <bhutchings@solarflare.com>
Thu, 21 Jul 2011 22:25:30 +0000 (15:25 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 5 Aug 2011 04:58:34 +0000 (21:58 -0700)
commit3de8ae6c0d1c0fb73243992adf87c7174028a531
tree7751ec6367207d85a23efa931fda82c0c7903662
parent468e4e387026f558ae1f1ac0fcc2f8985d4518b8
ethtool: Allow zero-length register dumps again

commit 67ae7cf1eeda777f79259c4c6cb17a0bd28dee71 upstream.

Some drivers (ab)use the ethtool_ops::get_regs operation to expose
only a hardware revision ID.  Commit
a77f5db361ed9953b5b749353ea2c7fed2bf8d93 ('ethtool: Allocate register
dump buffer with vmalloc()') had the side-effect of breaking these, as
vmalloc() returns a null pointer for size=0 whereas kmalloc() did not.

For backward-compatibility, allow zero-length dumps again.

Reported-by: Kalle Valo <kvalo@qca.qualcomm.com>
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/core/ethtool.c