]> git.karo-electronics.de Git - karo-tx-linux.git/commit
paride: fix potential information leak in pg_read()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 24 Oct 2011 14:53:54 +0000 (01:53 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Mon, 7 Nov 2011 02:40:25 +0000 (13:40 +1100)
commit3df835805d3a72a49aa0b1d43daab0d048569638
tree46c79d2da5543052305eaa227f0f46c09226717b
parentcce4c1ac2528588899530b011b17c812fba547da
paride: fix potential information leak in pg_read()

Smatch has a new check for Rosenberg type information leaks where structs
are copied to the user with uninitialized stack data in them.  i In this
case, the pg_write_hdr struct has a hole in it.

struct pg_write_hdr {
        char                       magic;                /*     0     1 */
        char                       func;                 /*     1     1 */
        /* XXX 2 bytes hole, try to pack */
        int                        dlen;                 /*     4     4 */

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Tim Waugh <tim@cyberelk.net>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/block/paride/pg.c