]> git.karo-electronics.de Git - linux-beck.git/commit
usb: musb: core: add pm_runtime_irq_safe()
authorFelipe Balbi <balbi@ti.com>
Mon, 2 Feb 2015 23:12:00 +0000 (17:12 -0600)
committerFelipe Balbi <balbi@ti.com>
Mon, 23 Feb 2015 06:18:53 +0000 (00:18 -0600)
commit3e43a0725637299a14369e3ef109c25a8ec5c008
tree0c675da5ee43efe981cf0dda5d5d0cff32d696fd
parent9ec36f7fe20ef919cc15171e1da1b6739222541a
usb: musb: core: add pm_runtime_irq_safe()

We need a pm_runtime_get_sync() call from
within musb_gadget_pullup() to make sure
registers are accessible at that time.

The problem is that musb_gadget_pullup() is
called with IRQs disabled and, because of that,
we need to tell pm_runtime that this pm_runtime_get_sync()
is IRQ safe.

We can simply add pm_runtime_irq_safe(), however, because
we need to make our read/write accessor function pointers
have been initialized before trying to use them. This means
that all pm_runtime initialization for musb_core needs to
be moved down so that when we call pm_runtime_irq_safe(),
the pm_runtime_get_sync() that it calls on the parent, won't
cause a crash due to NULL musb_read/write accessors.

Reported-by: Pali Rohár <pali.rohar@gmail.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/musb/musb_core.c