]> git.karo-electronics.de Git - mv-sheeva.git/commit
rtlwifi: rtl8192se firmware load can overflow target buffer
authorTim Gardner <tim.gardner@canonical.com>
Fri, 10 Feb 2012 00:19:52 +0000 (18:19 -0600)
committerJohn W. Linville <linville@tuxdriver.com>
Wed, 22 Feb 2012 19:48:53 +0000 (14:48 -0500)
commit3fccdcf5091eaaa0d7582bedbc035163b40714b9
tree65eea6253767eaed8ad1d559b0c061423d77622c
parent52e1409f72d629644b496db80c119e04ebabad90
rtlwifi: rtl8192se firmware load can overflow target buffer

Define RTL8190_MAX_RAW_FIRMWARE_CODE_SIZE which represents the
maximimum possible firmware file size. Use it in the definition
of the buffer which receives the firmware file data.

Set RTL8190_MAX_RAW_FIRMWARE_CODE_SIZE closer to the actual size of
the firmware file, e.g., 90000 (down from hard coded 164000). The current
size of rtlwifi/rtl8192sefw.bin is 88856.

Set max_fw_size to RTL8190_MAX_RAW_FIRMWARE_CODE_SIZE for the size limit
check. Fix the error case where max_fw_size is not cleared if the size
limit check fails.

Cc: Chaoming Li <chaoming_li@realsil.com.cn>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/rtlwifi/rtl8192se/fw.h
drivers/net/wireless/rtlwifi/rtl8192se/sw.c