]> git.karo-electronics.de Git - karo-tx-linux.git/commit
pch_uart: Fix dma channel unallocated issue
authorTomoya MORINAGA <tomoya.rohm@gmail.com>
Thu, 12 Apr 2012 01:47:50 +0000 (10:47 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Apr 2012 17:16:50 +0000 (10:16 -0700)
commit3fe36f180e16aec8a9f5e8a64676b0a315807471
tree809b0b9dbc5638b22bdcf4e09c3a92b20137550d
parent0a51fa60df2dbece7c9f2a686df59e896e76b4d3
pch_uart: Fix dma channel unallocated issue

commit af6d17cdc8c89aeb3101f0d27cd32fc0592b40b2 upstream.

This driver anticipates pch_uart_verify_port() is not called
during installation.
However, actually pch_uart_verify_port() is called during
installation.
As a result, memory access violation occurs like below.

0. initial value: use_dma=0
1. starup()
    - dma channel is not allocated because use_dma=0
2. pch_uart_verify_port()
    - Set use_dma=1
3. UART processing acts DMA mode because use_dma=1
     - memory access violation occurs!

This patch fixes the issue.

Solution:
Whenever pch_uart_verify_port() is called and then
dma channel is not allocated, the channel should be allocated.

Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/pch_uart.c