]> git.karo-electronics.de Git - karo-tx-linux.git/commit
The current implementation of the /dev/hpet driver couples opening the
authorMagnus Lynch <maglyx@gmail.com>
Wed, 3 Aug 2011 00:52:56 +0000 (10:52 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Thu, 4 Aug 2011 02:50:43 +0000 (12:50 +1000)
commit4053a87e85ee2dfa3b9d3c3b8f53ed936c0abfa5
treeb24d507b1f66c478069dc5ba4a94ddfb4fa8cee2
parentb4776e78e0d16ee6340b177bab34c406496d4c5e
The current implementation of the /dev/hpet driver couples opening the
device with allocating one of the (scarce) timers (aka comparators).  This
is a limitation in that the main counter may be valuable to applications
seeking a high-resolution timer who have no use for the interrupt
generating functionality of the comparators.

This patch alters the open semantics so that when the device is opened, no
timer is allocated.  Operations that depend on a timer being in context
implicitly attempt allocating a timer, to maintain backward compatibility.
 There is also an IOCTL (HPET_ALLOC_TIMER _IO) added so that the
allocation may be done explicitly.  (I prefer the explicit open then
allocate pattern but don't know how practical it would be to require all
existing code to be changed.)

/dev/hpet is accessed via mmap().  This is the only interface of /dev/hpet
that is actually used in practice.

[akpm@linux-foundation.org: coding-style tweaks]
[arnd@arndb.de: fix build]
Signed-off-by: Magnus Lynch <maglyx@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: john stultz <johnstul@us.ibm.com>
Acked-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/char/hpet.c
include/linux/hpet.h