]> git.karo-electronics.de Git - karo-tx-linux.git/commit
SCSI: Fix spurious request sense in error handling
authorJames Bottomley <JBottomley@Parallels.com>
Fri, 28 Mar 2014 17:50:17 +0000 (10:50 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 1 Jul 2014 03:12:00 +0000 (20:12 -0700)
commit4166c8b2ef2267465ba3381cd8cdb8d4c3bc9f3b
tree860029ee72ad2a709e3b5257188accbd48517b47
parent8a550bb5fc37bfc5d2bd345b3062e49b82bd0bac
SCSI: Fix spurious request sense in error handling

commit d555a2abf3481f81303d835046a5ec2c4fb3ca8e upstream.

We unconditionally execute scsi_eh_get_sense() to make sure all failed
commands that should have sense attached, do.  However, the routine forgets
that some commands, because of the way they fail, will not have any sense code
... we should not bother them with a REQUEST_SENSE command.  Fix this by
testing to see if we actually got a CHECK_CONDITION return and skip asking for
sense if we don't.

Tested-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/scsi/scsi_error.c