]> git.karo-electronics.de Git - karo-tx-linux.git/commit
Bluetooth: RFCOMM - Fix info leak in ioctl(RFCOMMGETDEVLIST)
authorMathias Krause <minipli@googlemail.com>
Wed, 15 Aug 2012 11:31:49 +0000 (11:31 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 2 Oct 2012 16:47:10 +0000 (09:47 -0700)
commit416a675770e625f4f5ccef3ce70b560abc94757a
tree555d167dcfdd625d27432b254ce10724d765c57d
parentf1c0a71da10bb2b9357b35a80ad315a353340c46
Bluetooth: RFCOMM - Fix info leak in ioctl(RFCOMMGETDEVLIST)

[ Upstream commit f9432c5ec8b1e9a09b9b0e5569e3c73db8de432a ]

The RFCOMM code fails to initialize the two padding bytes of struct
rfcomm_dev_list_req inserted for alignment before copying it to
userland. Additionally there are two padding bytes in each instance of
struct rfcomm_dev_info. The ioctl() that for disclosures two bytes plus
dev_num times two bytes uninitialized kernel heap memory.

Allocate the memory using kzalloc() to fix this issue.

Signed-off-by: Mathias Krause <minipli@googlemail.com>
Cc: Marcel Holtmann <marcel@holtmann.org>
Cc: Gustavo Padovan <gustavo@padovan.org>
Cc: Johan Hedberg <johan.hedberg@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/bluetooth/rfcomm/tty.c