]> git.karo-electronics.de Git - linux-beck.git/commit
sh_eth: do not reset PHY needlessly
authorSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Thu, 19 Dec 2013 22:41:12 +0000 (01:41 +0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 20 Dec 2013 00:09:38 +0000 (19:09 -0500)
commit4174ecd78f6591a3d1ec04738ef7bc900a11f5ce
treed1e30f9d0941602c58e71bb17f4ab39c67650f88
parent18be099badcfc4a12f058addc55c4270d5a8bec8
sh_eth: do not reset PHY needlessly

There's no need anymore to call phy_init_hw() to reset/resume the PHY from the
driver, as the call chain in phylib already has reached it, and so reset/resumed
the PHY (even resuming it twice). This duplicate reset is not only  needless, it
e.g. clears the PHY's interrupt enables just setup by phylib and so prevents the
expected IRQs from the PHY.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/renesas/sh_eth.c