]> git.karo-electronics.de Git - karo-tx-linux.git/commit
ocfs2: Morph the haphazard OCFS2_IS_VALID_GROUP_DESC() checks.
authorJoel Becker <joel.becker@oracle.com>
Thu, 13 Nov 2008 22:49:15 +0000 (14:49 -0800)
committerMark Fasheh <mfasheh@suse.com>
Mon, 5 Jan 2009 16:36:53 +0000 (08:36 -0800)
commit4203530613280281868b3ca36c817530bca3825c
tree57acc14e07bd97491a3781eb61e8c83c3c6e0151
parent68f64d471be38631d7196b938d9809802dd467fa
ocfs2: Morph the haphazard OCFS2_IS_VALID_GROUP_DESC() checks.

Random places in the code would check a group descriptor bh to see if it
was valid. The previous commit unified descriptor block reads,
validating all block reads in the same place.  Thus, these checks are no
longer necessary.  Rather than eliminate them, however, we change them
to BUG_ON() checks.  This ensures the assumptions remain true.  All of
the code paths to these checks have been audited to ensure they come
from a validated descriptor read.

Signed-off-by: Joel Becker <joel.becker@oracle.com>
Signed-off-by: Mark Fasheh <mfasheh@suse.com>
fs/ocfs2/ocfs2.h
fs/ocfs2/suballoc.c