]> git.karo-electronics.de Git - karo-tx-linux.git/commit
ASoC: tegra: s/IS_ERR_OR_NULL/IS_ERR/ for clk_get_sys
authorStephen Warren <swarren@nvidia.com>
Tue, 11 Jan 2011 19:48:53 +0000 (12:48 -0700)
committerMark Brown <broonie@opensource.wolfsonmicro.com>
Thu, 13 Jan 2011 14:18:03 +0000 (14:18 +0000)
commit422650e65a41a61b2f92396dfa4faa6a4df89913
tree955c75a7badff9dfee6fec4a3134e844ca27012d
parent1500b7b5ffaacb8199e0a61162f5d349fb19acbe
ASoC: tegra: s/IS_ERR_OR_NULL/IS_ERR/ for clk_get_sys

A recent discussion on linux-arm-kernel noted that the value returned by
clk_get_sys is an opaque token, and not strictly a pointer; it is
meaningful only to the clock API, clients should not dereference the value,
and the clock API must accept any non-IS_ERR value it returned.

Hence, only IS_ERR is appropriate to interpret the result, not
IS_ERR_OR_NULL.

I checked that clk_get_sys in both ASoC's for-next and Tegra's for-next
do behave as described; NULL is not returned in the case of error.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
sound/soc/tegra/tegra_asoc_utils.c
sound/soc/tegra/tegra_i2s.c