]> git.karo-electronics.de Git - karo-tx-linux.git/commit
watchdog: sp5100_tco: Set the AcpiMmioSel bitmask value to 1 instead of 2
authorTakahisa Tanaka <mc74hc00@gmail.com>
Sun, 3 Mar 2013 05:48:00 +0000 (14:48 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Mar 2013 19:18:00 +0000 (12:18 -0700)
commit423513b224cebcf59c3ecdc698f6ee6c741e8106
treed29f0ad7b0213177d5cb8cd42b9f665ff6192a84
parent80e04cfa5a91134861e53d3b8e9e71748e0c2abf
watchdog: sp5100_tco: Set the AcpiMmioSel bitmask value to 1 instead of 2

commit 81fc933f176cd95f757bfc8a98109ef422598b79 upstream.

The AcpiMmioSel bit is bit 1 in the AcpiMmioEn register, but the current
sp5100_tco driver is using bit 2.

See 2.3.3 Power Management (PM) Registers page 150 of the
AMD SB800-Series Southbridges Register Reference Guide [1].

        AcpiMmioEn - RW – 8/16/32 bits - [PM_Reg: 24h]
        Field Name        Bits  Default  Description
        AcpiMMioDecodeEn  0     0b       Set to 1 to enable AcpiMMio space.
        AcpiMMIoSel       1     0b       Set AcpiMMio registers to be memory-mapped or IO-mapped space.
                                         0: Memory-mapped space
                                         1: I/O-mapped space

The sp5100_tco driver expects zero as a value of AcpiMmioSel (bit 1).

Fortunately, no problems were caused by this typo, because the default
value of the undocumented misused bit 2 seems to be zero.

However, the sp5100_tco driver should use the correct bitmask value.

[1] http://support.amd.com/us/Embedded_TechDocs/45482.pdf

Signed-off-by: Takahisa Tanaka <mc74hc00@gmail.com>
Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/watchdog/sp5100_tco.h