]> git.karo-electronics.de Git - karo-tx-linux.git/commit
wake up s_wait_unfrozen when ->freeze_fs fails
authorKazuya Mio <k-mio@sx.jp.nec.com>
Thu, 1 Dec 2011 07:51:07 +0000 (16:51 +0900)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 30 May 2012 23:43:54 +0000 (00:43 +0100)
commit42bbdb289122169ec6d4f2a4bec848491c4408a7
treeb36456b346cb3be18f8ed8f2a9b670faf86053e0
parentd2b6ee559fe72ec90da4eb623f3f01135c5a1ec7
wake up s_wait_unfrozen when ->freeze_fs fails

commit e1616300a20c80396109c1cf013ba9a36055a3da upstream.

dd slept infinitely when fsfeeze failed because of EIO.
To fix this problem, if ->freeze_fs fails, freeze_super() wakes up
the tasks waiting for the filesystem to become unfrozen.

When s_frozen isn't SB_UNFROZEN in __generic_file_aio_write(),
the function sleeps until FITHAW ioctl wakes up s_wait_unfrozen.

However, if ->freeze_fs fails, s_frozen is set to SB_UNFROZEN and then
freeze_super() returns an error number. In this case, FITHAW ioctl returns
EINVAL because s_frozen is already SB_UNFROZEN. There is no way to wake up
s_wait_unfrozen, so __generic_file_aio_write() sleeps infinitely.

Signed-off-by: Kazuya Mio <k-mio@sx.jp.nec.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
fs/super.c