]> git.karo-electronics.de Git - linux-beck.git/commit
powerpc/85xx: mpc85xx ADS: remove pci exclude
authorDaniel Walker <danielwa@cisco.com>
Fri, 6 Nov 2015 00:31:21 +0000 (16:31 -0800)
committerScott Wood <scottwood@freescale.com>
Wed, 23 Dec 2015 00:23:21 +0000 (18:23 -0600)
commit433c858a61ac4192f821b71cd1370886e8395863
treef6e8e50205dbba5ae90f3ef4691a118ced9a37ea
parent4e9de5e9701f4f9206fc25249729881f8394850d
powerpc/85xx: mpc85xx ADS: remove pci exclude

This code was reworked in commit,

905e75c46dba5f3061049277e4eb7110beedba43

This change removed the fsl_add_bridge() which originally was above
the addition of the pci_exclude_device function. I think the assumption was that
the pci_exclude_device would prevent changes to the bridge PCI config after
it's been added. It seems it wasn't fully tested on MPC85xx ADS because
if you move the fsl_add_bridge() the pci_exclude_device is set in the machine
description then you can never update the PCI Config since the exclude
prevents it. This disrupts things like DMA.

This issue was extensively debugged by David Beazley.

Cc: xe-kernel@external.cisco.com
Cc: dbeazley@cisco.com
Cc: dwalker@fifo99.com
Signed-off-by: Daniel Walker <danielwa@cisco.com>
Signed-off-by: Scott Wood <scottwood@freescale.com>
arch/powerpc/platforms/85xx/mpc85xx_ads.c