]> git.karo-electronics.de Git - karo-tx-linux.git/commit
futex: Forbid uaddr == uaddr2 in futex_wait_requeue_pi()
authorDarren Hart <dvhart@linux.intel.com>
Fri, 20 Jul 2012 18:53:31 +0000 (11:53 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 9 Aug 2012 23:24:50 +0000 (00:24 +0100)
commit4344b8578fb31bb06abd397219ac0376f116f6f2
tree905acf2efcf565065dbe590671856de8d4b066a1
parent4ccf9739188a122c229a7839ee0af89c91f26029
futex: Forbid uaddr == uaddr2 in futex_wait_requeue_pi()

commit 6f7b0a2a5c0fb03be7c25bd1745baa50582348ef upstream.

If uaddr == uaddr2, then we have broken the rule of only requeueing
from a non-pi futex to a pi futex with this call. If we attempt this,
as the trinity test suite manages to do, we miss early wakeups as
q.key is equal to key2 (because they are the same uaddr). We will then
attempt to dereference the pi_mutex (which would exist had the futex_q
been properly requeued to a pi futex) and trigger a NULL pointer
dereference.

Signed-off-by: Darren Hart <dvhart@linux.intel.com>
Cc: Dave Jones <davej@redhat.com>
Link: http://lkml.kernel.org/r/ad82bfe7f7d130247fbe2b5b4275654807774227.1342809673.git.dvhart@linux.intel.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
kernel/futex.c