]> git.karo-electronics.de Git - karo-tx-linux.git/commit
device-dax: fix 'passing zero to ERR_PTR()' warning
authorDan Williams <dan.j.williams@intel.com>
Wed, 12 Jul 2017 20:42:37 +0000 (13:42 -0700)
committerDan Williams <dan.j.williams@intel.com>
Mon, 17 Jul 2017 18:43:58 +0000 (11:43 -0700)
commit43fe51e11c194a6576634585f81ba33e104194a5
treecf27724a7c3a0c200e167068d1e2346dedbc5c52
parent4e3f0701f25ab194c5362576b1146a1e6cc6c2e7
device-dax: fix 'passing zero to ERR_PTR()' warning

Dan Carpenter reports:

    The patch 7b6be8444e0f: "dax: refactor dax-fs into a generic provider
    of 'struct dax_device' instances" from Apr 11, 2017, leads to the
    following static checker warning:

        drivers/dax/device.c:643 devm_create_dev_dax()
        warn: passing zero to 'ERR_PTR'

Fix the case where we inadvertently leak 0 to ERR_PTR() by setting at
every error case, and make it clear that 'count' is never 0.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/dax/device.c