]> git.karo-electronics.de Git - karo-tx-linux.git/commit
tracing: Do not add event files for modules that fail tracepoints
authorSteven Rostedt (Red Hat) <rostedt@goodmis.org>
Wed, 26 Feb 2014 18:37:38 +0000 (13:37 -0500)
committerSteven Rostedt <rostedt@goodmis.org>
Tue, 4 Mar 2014 02:11:05 +0000 (21:11 -0500)
commit45ab2813d40d88fc575e753c38478de242d03f88
tree1859b05c3be128fd1c0a97c09c2fade4ad91e2e2
parent0414855fdc4a40da05221fc6062cccbc0c30f169
tracing: Do not add event files for modules that fail tracepoints

If a module fails to add its tracepoints due to module tainting, do not
create the module event infrastructure in the debugfs directory. As the events
will not work and worse yet, they will silently fail, making the user wonder
why the events they enable do not display anything.

Having a warning on module load and the events not visible to the users
will make the cause of the problem much clearer.

Link: http://lkml.kernel.org/r/20140227154923.265882695@goodmis.org
Fixes: 6d723736e472 "tracing/events: add support for modules to TRACE_EVENT"
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: stable@vger.kernel.org # 2.6.31+
Cc: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
include/linux/tracepoint.h
kernel/trace/trace_events.c
kernel/tracepoint.c